Adding functionality to render a table from a HTML file #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we have more test? |
|
Could you please add tests for broken html? Thanks. |
|
@mattn I already added a test for when there are some unclosed tags. What other edge cases should I test for ? |
|
For example: |
Okay added that, it returns : // Output: *=====*
// | BAR |
// *=====*
// | foo |
// *=====* |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completing one of the todos on the readme by adding the functionality to render table from html file. This PR adds a new dependency to the package: golang.org/x/net/html to help with parsing the html.